[ https://issues.apache.org/jira/browse/GIRAPH-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123935#comment-13123935 ]
Avery Ching edited comment on GIRAPH-48 at 10/10/11 7:40 AM: ------------------------------------------------------------- Yeah, Eclipse automatically does that. The main change is very small: int numWorkers = conf.getInt(GiraphJob.MAX_WORKERS, numTasks); - // if the number of flush threads is unset, it is set to - // the number of max workers. - int numFlushThreads = conf.getInt(GiraphJob.MSG_NUM_FLUSH_THREADS, numWorkers-1); + // If the number of flush threads is unset, it is set to + // the number of max workers - 1 or a minimum of 1. + int numFlushThreads = + Math.max(conf.getInt(GiraphJob.MSG_NUM_FLUSH_THREADS, + numWorkers - 1), + 1); Thanks for the quick review! I've checked it in. was (Author: aching): Yeah, Eclipse automatically does that. The main change is very small: int numWorkers = conf.getInt(GiraphJob.MAX_WORKERS, numTasks); - // if the number of flush threads is unset, it is set to - // the number of max workers. - int numFlushThreads = conf.getInt(GiraphJob.MSG_NUM_FLUSH_THREADS, numWorkers-1); + // If the number of flush threads is unset, it is set to + // the number of max workers - 1 or a minimum of 1. + int numFlushThreads = + Math.max(conf.getInt(GiraphJob.MSG_NUM_FLUSH_THREADS, + numWorkers - 1), + 1); Thanks for the quick review! I've check it in. > All tests failing under non-secure build > ---------------------------------------- > > Key: GIRAPH-48 > URL: https://issues.apache.org/jira/browse/GIRAPH-48 > Project: Giraph > Issue Type: Bug > Reporter: Jakob Homan > Priority: Critical > > After GIRAPH-12, quite a lot of tests are failing when run under non-secure > hadoop: > {noformat}mvn -Dhadoop=non_secure clean test{noformat} > results in: > {noformat}Failed tests: > testSuperstepBalancer(org.apache.giraph.TestVertexRangeBalancer) > testBspCheckpoint(org.apache.giraph.TestManualCheckpoint) > testBspSuperStep(org.apache.giraph.TestBspBasic) > testBspMsg(org.apache.giraph.TestBspBasic) > testBspCombiner(org.apache.giraph.TestBspBasic) > testBspPageRank(org.apache.giraph.TestBspBasic) > testBspShortestPaths(org.apache.giraph.TestBspBasic) > testMutateGraph(org.apache.giraph.TestMutateGraphVertex) > testContinue(org.apache.giraph.TestJsonBase64Format){noformat} > rolling back to the previous commit, the tests pass. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira