On December 29, 2016 12:47:01 AM PST, Eric Wong <e...@80x24.org> wrote: >Eduardo Habkost <ehabk...@redhat.com> wrote: >> git-am has options to enable --message-id and --3way by default, >> but no option to enable --signoff by default. Add a "am.signoff" >> config option. > >I'm not sure this is a good idea. IANAL, but a sign-off >has some sort of legal meaning for this project (DCO) >and that would be better decided on a patch-by-patch basis >rather than a blanket statement. > >I don't add my SoB to patches (either my own or received) until >I'm comfortable with it; and I'd rather err on the side of >forgetting and being prodded to resubmit rather than putting >an SoB on the wrong patch. > > >(I'm barely online today, no rush needed in responding)
I don't know what is true for all projects, but I can't believe making it configurable would cause problems.... If you don't want it you don't have to enable it. I suppose your argument is that we shouldn't ever make it automatically but... I know that many people who receive email patches, apply them, then forward those to another group add their sign off as a mark of "yes I certify that this is legally OK" so I think this would be useful. Thanks Jake
