On Thu, Dec 29, 2016 at 01:42:13PM -0800, Junio C Hamano wrote: > Eric Wong <e...@80x24.org> writes: > > > Eduardo Habkost <ehabk...@redhat.com> wrote: > >> git-am has options to enable --message-id and --3way by default, > >> but no option to enable --signoff by default. Add a "am.signoff" > >> config option. > > > > I'm not sure this is a good idea. IANAL, but a sign-off > > has some sort of legal meaning for this project (DCO) > > and that would be better decided on a patch-by-patch basis > > rather than a blanket statement. > > IANAL either, but we have been striving to keep output of > > $ git grep '\.signoff' Documentation > > empty to keep Sign-off meaningful. > > Adding more publicized ways to add SoB without thinking will make it > harder to argue against one who tells the court "that log message > ends with a SoB by person X but it is very plausible that it was > done by inertia without person X really intending to certify what > DCO says, and the SoB is meaningless".
This sounds completely reasonable to me. I now see that the config option was already proposed in 2011 and the same arguments were discussed. Sorry for the noise. > > > I don't add my SoB to patches (either my own or received) until > > I'm comfortable with it; and I'd rather err on the side of > > forgetting and being prodded to resubmit rather than putting > > an SoB on the wrong patch. > -- Eduardo
