Re: [PATCH 4/7] grep: re-order rev-parsing loop

[Brandon Williams]

On 02/14, Jeff King wrote:
> -             /* Is it a rev? */
> -             if (!get_sha1_with_context(arg, 0, sha1, &oc)) {
> -                     struct object *object = parse_object_or_die(sha1, arg);
> -                     if (!seen_dashdash)
> -                             verify_non_filename(prefix, arg);
> -                     add_object_array_with_path(object, arg, &list, oc.mode, 
> oc.path);
> -                     continue;
> -             }
> -             break;
> +
> +             /* Stop at the first non-rev */
> +             if (get_sha1_with_context(arg, 0, sha1, &oc))
> +                     break;
> +
> +             object = parse_object_or_die(sha1, arg);
> +             if (!seen_dashdash)
> +                     verify_non_filename(prefix, arg);
> +             add_object_array_with_path(object, arg, &list, oc.mode, 
> oc.path);

This is much more readable!

-- 
Brandon Williams