On 02/10/17 14:44, Pranit Bauva wrote: [snip] >> Look for []-ed comments in the commit messages for a note of >> the changes I made to your original patches, in patches #2, >> #4, #7-9, #11-12 and #14. >> >> The commits I added, which are just WIP, are as follows: >> >> $ git log --oneline bisect~12..bisect >> 7d7117040 (raj/bisect, bisect) bisect--helper: convert to struct object_id >> 188ea5855 bisect--helper: add the get_bad_commit() function >> b75f46fb4 bisect--helper: add a log_commit() helper function >> 4afc34403 bisect--helper: reduce the scope of a variable >> 62495f6ae bisect--helper: remove useless sub-expression in condition >> 964f4e2b0 bisect--helper: set correct term from --term-new= option >> 62efc099f bisect--helper: remove redundant assignment to has_double_dash >> d35950b92 bisect--helper: remove redundant goto's >> b33f313ac bisect--helper: remove space just before \n in string >> 3eb407156 bisect--helper: remove some unnecessary braces >> c2b89c9b8 bisect--helper: add some vertical whitespace >> 8c883701c bisect--helper: fix up some coding style issues >> $ >> >> Again IIRC, there are a couple of bug fixes in these commits ... > > There is actually a major bug in the later part of previous series > mostly in the bisect-next which actually caused delays. I think you > have fixed it in your commit 682d0bff0. Although I would need to have > a closer look at it. In original series, I did get a sigserv, and as > you mention it in the commit that you have fixed it.
Yes, I also meant to tidy that up by removing some, now redundant, initialisation later in that function. Note, that wasn't the only bug! (I have probably forgotten some of them, but look at 964f4e2b0, for example). ATB, Ramsay Jones
