On Tue, Mar 27, 2018 at 12:14 AM, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > However, it seems that something is off, as > ba5bec9589e9eefe2446044657963e25b7c8d88e is reported as fine on Windows: > https://travis-ci.org/git/git/jobs/358260023 (while there is clearly a red > X next to that commit in > https://github.com/git/git/commits/ba5bec9589e9eefe2446044657963e25b7c8d88e, > that X is due to a hiccup on macOS). > > It seems that the good-trees feature for Travis does not quite work as > intended. Gábor?
AFAICT it works as expected. When a build job encounters a commit with a tree that has previously been built and tested successfully, then first it says so, like this: https://travis-ci.org/szeder/git/jobs/347295038#L635 and then skips the rest of the build job (see the 'exit 0' a few lines later). In case of this Windows build job we haven't seen this tree yet: https://travis-ci.org/git/git/jobs/358260023#L467 so the build job continues as usual (see the 'test -z Windows' two lines later). Unfortunately, I have no idea about how the rest of the Windows build job is supposed to work...
