Hi Junio, On Thu, May 10, 2018 at 2:27 AM, Junio C Hamano <gits...@pobox.com> wrote: > Stefan Beller <sbel...@google.com> writes: > >> So this would go with the latest sb/object-store-alloc ? >> >> My impression was that we never call repo_clear() on >> the_repository, which would allow us to special case >> the_repository further just as I did in v2 of that series[1] by >> having static allocations for certain objects in case of \ >> the_repository. >> >> [1] https://public-inbox.org/git/20180501213403.14643-14-sbel...@google.com/ >> >> We could just deal with all the exceptions, but that makes repo_clear >> ugly IMHO. > > So perhaps > > void repo_clear(...) > { > + if (repo == the_repository) > + BUG("repo_clear() called on the repository"); > ... > > or something?
This would work, but Duy convinced me to have repo_clear working on the_repository is a good idea by giving a minimal test helper[1], which helped me to find leaks[2][3], so I'd rather go with the solution by Duy in [4] from a developers perspective. Stefan [1] https://public-inbox.org/git/cacsjy8c7n2w821h8yr8vakdcsoscdtqi_yt7z8hhndo-vxj...@mail.gmail.com/ https://gist.github.com/pclouds/86a2df6c28043f1b6fa3d4e72e7a1276 [2] https://public-inbox.org/git/20180510001211.163692-1-sbel...@google.com/ [3] https://public-inbox.org/git/20180509234059.52156-1-sbel...@google.com/ [4] https://public-inbox.org/git/CACsJy8AdJcQpiGrR3p6xfuqU0=qoP3=stgbwrnckdfka6di...@mail.gmail.com/
