On 7/23/2018 4:41 PM, Jonathan Tan wrote:
+ if (parse_commit(list[i]) ||
+ list[i]->generation < min_generation)
Here...
+ if (parse_commit(parent->item) ||
+ parent->item->date <
min_commit_date ||
+ parent->item->generation <
min_generation)
...and here, would parse_commit_or_die() be better? I think that a
function that returns a definitive answer (either the commits are
reachable or not) should die when the commits cannot be parsed.
I'm hesitant to add _or_die() here, when the previous implementation
only used parse_object() or parse_commit(), so would not die when
parsing fails. The same holds true for the other methods that call
can_all_from_reach().
Thanks,
-Stolee
