On Mon, Oct 15, 2018 at 5:47 AM Johannes Schindelin via GitGitGadget
<gitgitgad...@gmail.com> wrote:
> Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de>
> ---
> diff --git a/compat/mingw.c b/compat/mingw.c
> @@ -1800,16 +1800,27 @@ int mingw_getpagesize(void)
> struct passwd *getpwuid(int uid)
> {
> + static unsigned initialized;
> static char user_name[100];
> - static struct passwd p;
> + static struct passwd *p;
>
> + if (initialized)
> + return p;
> +
> + len = sizeof(user_name);
> + if (!GetUserName(user_name, &len)) {
> + initialized = 1;
> return NULL;
> + }
If GetUserName() fails, that failure is recorded (as "initialized=1"
and 'p' is still NULL), so subsequent invocations just return NULL
without doing any more work. Makes sense.
> + p = xmalloc(sizeof(*p));
> + p->pw_name = user_name;
> + p->pw_gecos = "unknown";
> + p->pw_dir = NULL;
> +
> + initialized = 1;
> + return p;
> }
