On Wed, Oct 24, 2018 at 4:06 PM Slavica Djukic
<slavicadj.ip2...@gmail.com> wrote:
> This is part of enhancement request that ask for 'git stash' to work
> even if 'user.name' and 'user.email' are not configured.
> Due to an implementation detail, git-stash undesirably requires
> 'user.name' and 'user.email' to be set, but shouldn't.
Thanks for re-rolling. This version looks better. One comment below...
> Signed-off-by: Slavica Djukic <slawic...@hotmail.com>
> ---
> diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
> @@ -1156,4 +1156,17 @@ test_expect_success 'stash -- <subdir> works with
> binary files' '
> +test_expect_failure 'stash works when user.name and user.email are not set' '
> + test_commit 1 &&
> + test_config user.useconfigonly true &&
> + test_config stash.usebuiltin true &&
> + sane_unset GIT_AUTHOR_NAME &&
> + sane_unset GIT_AUTHOR_EMAIL &&
> + sane_unset GIT_COMMITTER_NAME &&
> + sane_unset GIT_COMMITTER_EMAIL &&
> + test_must_fail git config user.email &&
Instead of simply asserting that 'user.email' is not set here, you
could instead proactively ensure that it is not set. That is, instead
of the test_must_fail(), do this:
test_unconfig user.email &&
test_unconfig user.name &&
> + echo changed >1.t &&
> + git stash
> +'
> +
> test_done
> --
> 2.19.1.windows.1
>
