Eric Sunshine <sunsh...@sunshineco.com> writes: >> + test_commit 1 && >> + test_config user.useconfigonly true && >> + test_config stash.usebuiltin true && >> + sane_unset GIT_AUTHOR_NAME && >> + sane_unset GIT_AUTHOR_EMAIL && >> + sane_unset GIT_COMMITTER_NAME && >> + sane_unset GIT_COMMITTER_EMAIL && >> + test_must_fail git config user.email && > > Instead of simply asserting that 'user.email' is not set here, you > could instead proactively ensure that it is not set. That is, instead > of the test_must_fail(), do this: > > test_unconfig user.email && > test_unconfig user.name &&
Yes, it would be more in line with what is done to the environment variables and to other configuration variables in the same block. Not that I think that this inconsistency is end of the world ;-) Thanks. >> + echo changed >1.t && >> + git stash >> +' >> + >> test_done >> -- >> 2.19.1.windows.1 >>
