On Thu, Sep 05, 2019 at 06:25:26PM -0400, Taylor Blau wrote: > On Thu, Sep 05, 2019 at 03:10:05PM -0700, Denton Liu wrote: > > In many test scripts, there are bespoke definitions of the single quote > > that are some variation of this: > > > > SQ="'" > > > > Define a common $SQ variable in test-lib.sh and replace all usages of > > these bespoke variables with the common one. > > > > This change was done by running `git grep =\"\'\" t/` and > > `git grep =\\\\\'` and manually changing the resulting definitions and > > corresponding usages. > > Signed-off-by: Denton Liu <liu.den...@gmail.com> > > --- > > > > [whoops, forgot to include the mailing list in the last email] > > > > Sorry, I wrote this patch up before I saw the email about leaving this > > as #leftoverbits. No point in letting it go to waste, though. > > Thanks for doing this. I marked it as '#leftoverbits' in case anybody > hosting an Outreachy intern might be interested in having something > small for a newcomer to dip their toes into sending to the mailing list.
Oh, how silly of me. I was thinking about [1], which I said would be good #leftoverbits material. This thread was tagged by Junio, not me. The rest of my point stands, though ;). > But, there's no shortage of other such tasks, I'd assume, so it's good > that you cleaned these up. > > Both of your 'git grep' invocations look correct to me, so the patch > below looks like an obviously-correct result. Thanks. > > -Taylor Thanks, Taylor [1]: https://public-inbox.org/git/20190904212121.GB20904@syl.local/
