Am 19.10.19 um 00:04 schrieb Denton Liu: > diff --git a/t/t7408-submodule-reference.sh b/t/t7408-submodule-reference.sh > index 34ac28c056..9e62d43cac 100755 > --- a/t/t7408-submodule-reference.sh > +++ b/t/t7408-submodule-reference.sh > @@ -123,7 +123,7 @@ test_expect_success 'missing submodule alternate fails > clone and submodule updat > test_must_fail git submodule update --init && > # and we have no alternates: > test_must_fail test_alternate_is_used > .git/modules/sub/objects/info/alternates sub &&
Here's another incorrect use of test_must_fail (not the only instance in this file). Looks like we would need a "test_alternate_is_not_used" helper. > - test_must_fail test_path_is_file sub/file1 > + test_path_is_missing sub/file1 > ) > ' I suggest to drop this patch; it doesn't fit the theme of this series, and if you attempt to do it right, you'll quickly find a deep rabbit hole. -- Hannes
