Jeff King <p...@peff.net> writes: > But I do not think fill_one is the right interface for it. The reason > has_changes calls get_textconv separately is that we do not want to fill > the buffer (which may be expensive) if we can avoid it. So the correct > sequence is: ... > If you turned fill_one into "fill_both_sides" then you could share > the code between diff_grep/pickaxe and do it in the right order in the > helper.
Yeah, I think that is a good way to refactor. A patch later in the series will be killing fill_one() anyway ;-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
