[PATCH 2/3] diffcore-pickaxe: fix leaks in "log -S" and "log -G"

[Junio C Hamano]

The diff_grep() and has_changes() functions had early return
codepaths for unmerged filepairs, which simply returned 0.  When we
taught textconv filter to them, one was ignored and continued to
return early without freeing the result filtered by textconv, and
the other had a failed attempt to fix, which allowed the planned
return value 0 to be overwritten by a bogus call to contains().

Signed-off-by: Junio C Hamano <gits...@pobox.com>
---
 diffcore-pickaxe.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/diffcore-pickaxe.c b/diffcore-pickaxe.c
index bfaabab..cadb071 100644
--- a/diffcore-pickaxe.c
+++ b/diffcore-pickaxe.c
@@ -99,9 +99,10 @@ static int diff_grep(struct diff_filepair *p, struct 
diff_options *o,
 
        if (!DIFF_FILE_VALID(p->one)) {
                if (!DIFF_FILE_VALID(p->two))
-                       return 0; /* ignore unmerged */
-               /* created "two" -- does it have what we are looking for? */
-               hit = !regexec(regexp, mf2.ptr, 1, &regmatch, 0);
+                       hit = 0; /* ignore unmerged */
+               else
+                       /* created "two" -- does it have what we are looking 
for? */
+                       hit = !regexec(regexp, mf2.ptr, 1, &regmatch, 0);
        } else if (!DIFF_FILE_VALID(p->two)) {
                /* removed "one" -- did it have what we are looking for? */
                hit = !regexec(regexp, mf1.ptr, 1, &regmatch, 0);
@@ -229,8 +230,9 @@ static int has_changes(struct diff_filepair *p, struct 
diff_options *o,
        if (!DIFF_FILE_VALID(p->one)) {
                if (!DIFF_FILE_VALID(p->two))
                        ret = 0; /* ignore unmerged */
-               /* created */
-               ret = contains(&mf2, o, regexp, kws) != 0;
+               else
+                       /* created */
+                       ret = contains(&mf2, o, regexp, kws) != 0;
        }
        else if (!DIFF_FILE_VALID(p->two)) /* removed */
                ret = contains(&mf1, o, regexp, kws) != 0;
-- 
1.8.2-588-gbf1c992

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html