On Wed, Apr 10, 2013 at 2:57 AM, Felipe Contreras <felipe.contre...@gmail.com> wrote: > There's no point in calling a separate function that is only used in one > place. Specially considering that there's no need to call compgen, and
s/Specially/Especially/ > we traverse the words ourselves both in __gitcompadd, and __gitcomp_1. s/ourselves/ourself/ > So lets squash the functions together, and traverse only once. s/lets/let's/ > This improves performance. For N number of words: > > == 1 == > original: 0.002s > new: 0.000s > == 10 == > original: 0.005s > new: 0.001s > == 100 == > original: 0.009s > new: 0.006s > == 1000 == > original: 0.027s > new: 0.019s > == 10000 == > original: 0.163s > new: 0.151s > == 100000 == > original: 1.555s > new: 1.497s > > No functional changes. > > Signed-off-by: Felipe Contreras <felipe.contre...@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
