On Sun, Oct 6, 2013 at 11:51 AM, Philip Oakley <philipoak...@iee.org> wrote: > From: "Johan Herland" <jo...@herland.net> >> Cc: Eric Wong <normalper...@yhbt.net> > > Excuse my ignorance, but what is the "Carbon copy:" line meant to signify? > Should it be a double "Signed-of-by:" or one of the other "-by:" lines?
No, it's not a Signed-off-by, it's merely a hint to someone that they might want to take a closer look at this patch. In this case, I'm Cc-ing Eric Wong, as he is the main git-svn author, and I consider his feedback on these patches very valuable. When I add a Cc: to the commit message, git send-email picks it up, and adds him to the Cc-list of the resulting email. I could have achieved the same by passing --cc "Eric ..." directly to git-send-email, but sometimes there might be quite a while between preparing the commit and running git send-email, and in those cases adding the Cc to the commit message saves me from forgetting to Cc him when I some time later get around to running git send-email. That said, my hope is obviously that Eric will have the time/energy/motivation to review these patches, so that I (or someone else) can later replace the "Cc:" line with a corresponding "Reviewed-by:" or "Acked-by:". Even if that does not happen, and the "Cc:" line ends up in the recorded history of Git, I don't consider that a big problem either; a 'git log origin/master | grep "^\s*Cc: " | wc -l' yields 148 existing cases... Hope that helps, ...Johan -- Johan Herland, <jo...@herland.net> www.herland.net -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
