On Wed, May 14, 2014 at 10:52:28AM -0700, Junio C Hamano wrote: > I do not think checking 'text' is the right way to do this. The > attribute controls the eof normalization, and people sometimes want > to keep CRLF terminated files in the repository no matter what the > platform is (an example I heard is a sample protocol exchange over > textual network protocol such as HTTP and SMTP), and the way to do > so is to unset it. That would still let them look for patterns in > and compare the changes to these paths. > > Looking for "Marking files as binary" in gitattributes(5) gives us a > more authoritative alternative, I think. In short: > > - If 'diff' is Unset, or > - If 'diff' is Set to X and diff.X.binary is true > > then the contents are not suitable for human consumption.
I responded elsewhere in the thread that I think the patch under discussion is redundant at this point, but just to clarify: grep currently uses the rules you give above, as it builds on the userdiff driver code. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
