Hi Peff, On Wed, 14 May 2014, Jeff King wrote:
> On Wed, May 14, 2014 at 05:44:19PM +0200, Stepan Kasal wrote: > > > From: Johannes Schindelin <johannes.schinde...@gmx.de> > > Date: Mon, 8 Nov 2010 16:10:43 +0100 > > > > Incidentally, this makes grep -I respect the "binary" attribute (actually, > > the "-text" attribute, but "binary" implies that). > > Hrm. Is this patch still necessary? In the time since this patch was > written, we did 0826579 (grep: load file data after checking > binary-ness, 2012-02-02) I have no time to test this but I trust that you made sure that it works as advertised. In my case, there were about 500 gigabytes of image data intermixed with code, and waiting for 'git grep' was not funny at all (and I did not have time back then to go through a full code submission cycle on the Git mailing list, either). So I guess we can drop my patch. Ciao, Johannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
