Michael Haggerty wrote: > Declare the return value to be const to make it clear that we aren't > giving callers permission to write over the string that it points at. > (The return value is the filename field of a struct lock_file, which > can be used by a signal handler at any time and therefore shouldn't be > tampered with.) > > Signed-off-by: Michael Haggerty <mhag...@alum.mit.edu> > --- > builtin/commit.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Jonathan Nieder <jrnie...@gmail.com> I wonder if we should just bite the bullet and make lock_file an opaque struct with accessors for int fd and const char *filename. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
