On 09/16/2014 10:39 PM, Jonathan Nieder wrote: > Jonathan Nieder wrote: >> Michael Haggerty wrote: > >>> --- a/lockfile.c >>> +++ b/lockfile.c >>> @@ -276,7 +276,7 @@ void rollback_lock_file(struct lock_file *lk) >>> return; >>> >>> if (lk->fd >= 0) >>> - close(lk->fd); >>> + close_lock_file(lk); >> >> Doesn't need to be guarded by the 'if'. > > Err, yes it does. > > Why doesn't close_lock_file bail out early when fd < 0?
OK, I will change close_lock_file() to exit (with no error) when fd < 0. Then this "if" can also go away. Thanks, Michael -- Michael Haggerty mhag...@alum.mit.edu -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
