On Tue, Dec 9, 2014 at 3:14 PM, Johannes Sixt <j...@kdbg.org> wrote: > Am 20.11.2014 um 16:17 schrieb Jeff King: >> +#define COLOR_FOREGROUND '3' >> +#define COLOR_BACKGROUND '4' > > This (COLOR_BACKGROUND) causes an ugly redefinition warning on Windows, > because we inherit a definition from a Windows header. How would you > like it fixed? A different name or #undef in front of it?
One way this sort of problem was handled in the past was the sanitize the preprocessor namespace [1]. [1]: https://github.com/git/git/blob/master/compat/mingw.h#L80 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
