Sudhanshu Shekhar <sudshekha...@gmail.com> writes:

> +test_expect_success 'reset - while having file named - and no previous 
> branch' '

I like having the expected behavior in the test name too. e.g. add
"fails" at the end of the sentence.

> +test_expect_success 'reset - in the presence of file named - with previous 
> branch' '
> +     echo "Unstaged changes after reset:" >expect &&
> +     echo "M -" >>expect &&
> +     echo "M 1" >>expect &&

Here and elsewhere: why not

        cat >expect <<-EOF
        Unstaged changes after reset:
        M -
        M 1

?

> +     rm -rf no_previous &&

That would be best done in a test_when_finished, so that the directory
is removed regardless of whether the test failed before this line or
not.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to