On Thu, Mar 19, 2015 at 9:32 PM, Jeff King <p...@peff.net> wrote: > On Thu, Mar 19, 2015 at 09:16:52PM -0400, Eric Sunshine wrote: > >> > --- /dev/null >> > +++ b/t/t5312-prune-corruption.sh >> > @@ -0,0 +1,104 @@ >> > +# we do not want to count on running pack-refs to >> > +# actually pack it, as it is perfectly reasonable to >> > +# skip processing a broken ref >> > +test_expect_success 'create packed-refs file with broken ref' ' >> > + rm -f .git/refs/heads/master && >> > + cat >.git/packed-refs <<-EOF >> >> Broken &&-chain. > > Thanks. I notice that a large number of broken &&-chains are on > here-docs. I really wish you could put the && on the "EOF" line at the > end of the here-doc. I understand _why_ that this not the case, but > mentally it is where I want to type it, and I obviously sometimes fail > to go back and fix it. I don't think there's a better solution in POSIX > sh, though.
I wonder if test-lint could be enhanced to detect this sort of problem? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
