Junio C Hamano <gits...@pobox.com> writes: > Eric Sunshine <sunsh...@sunshineco.com> writes: > >> It does feel like a layering violation. If moved to the run-command >> API, it could given one of the following names or something better: >> >> run_command_capture() >> capture_command() >> command_capture() >> run_command_with_output() >> capture_output() > > Sound like a good suggestion (but I haven't read the users of the > proposed function, after doing which I might change my mind---I'll > see).
Now I read the callers, it does look like this new function better fits in the run-command suite, essentially allowing us to do what we would do with $(cmd) or `cmd` in shell and Perl scripts, even though I do not particularly agree with the phrase "layering violation" to call its current placement. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
