Remi Galan Alfonso <remi.galan-alfo...@ensimag.grenoble-inp.fr>
writes:
> Thank you for reviewing the code.
>
> Eric Sunshine<sunsh...@sunshineco.com> writes:
>> > + # To uppercase
>> > + checkLevel=$(echo "$checkLevel" | tr '[:lower:]' '[:upper:]')
>>
>> Is there precedence elsewhere for recognizing uppercase and lowercase
>> variants of config values?
>
> It seems to be commonly used when parsing options in the C files
> through strcasecmp. For exemple, in config.c:818 :
> if (!strcmp(var, "core.safecrlf")) {
> if (value && !strcasecmp(value, "warn")) {
> [...]
> However we didn't see any precedence in shell files. Do you think we
> should remove it?
I think there is a difference between (silently) accepting just to
be lenient and documenting and advocating mixed case uses.
Personally, I'd rather not to see gratuitous flexibility to allow
the same thing spelled in 47 different ways for no good reason.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
