Matthieu Moy <matthieu....@grenoble-inp.fr> writes: > You're using $1 and $2 only to redirect input and output. I would find > it more elegant to write todo_list_to_sha_list as a filter, and do the > redirection in the call site (to keep the option of using > todo_list_to_sha_list in a pipe).
If I understood correctly, then the calling line would look like: > todo_list_to_sha_list <"$todo".backup >"$todo".oldsha1 ? Should I do the same for the function warn_file ? Meaning > warn_file <"$todo".miss instead of > warn_file "$todo".miss The other points mentioned have been corrected. Thanks, Rémi -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
