On Fri, Jun 12, 2015 at 8:29 PM, Karthik Nayak <karthik....@gmail.com> wrote: > On 06/12/2015 11:34 PM, Junio C Hamano wrote: >> >> Karthik Nayak <karthik....@gmail.com> writes: >> >>>> What change since 9f613dd do you have in mind, exactly, though? >>> >>> >>> Well initially the atoms were indexed into used_atom array, which >>> later was removed. Hence the comment becomes obsolete. >> >> >> Later in which commit? In builtin/for-each-ref.c in the version >> after applying patches 1-3 of this series on top of master, I still >> see used_atom[] array there, so...? >> > > Uh! My bad. > Ignore this! I think I got confused, On having a look now that patch is > not needed. Sorry.
I think it is needed later when "struct ref_sort" is moved into ref-filter.h, because then the used_atom[] array is not moved. So either: 1) you update the comment when you move "struct ref_sort" into ref-filter.h, but then the downside is that there is not only code movement in the patch that moves "struct ref_sort" into ref-filter.h, or 2) you explain that, as "struct ref_sort" will be moved later while the used_atom[] array will not be moved, the direct connection between the comment and used_atom[] will be broken, and you need to prepare for that because you want to avoid solution 1) as you want only code movement when moving "struct ref_sort" into ref-filter.h. Hope this helps, Christian. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
