Lawrence Siebert <lawrencesieb...@gmail.com> writes: > Ok, I'll fix that.
(Note: this is a typical example of why we don't top-post here. I made several remarks and I can't know what "that" refers to) (Meta-note: don't take the note as agressive, I know that top-posting is the norm in many other places, I'm just giving you a glimpse of the local culture ;-) ). > If it's acceptable practice, I'll just squash everything I do on this > feature and it's tests into one commit with a more detailed comment, > and send the patch for that. I think at least two patches are better: your PATCH 1 is a typical preparation step, best reviewed alone in its own patch. Splitting history into several patches is good, but each patch should correspond to one logical step. Splitting code Vs doc Vs tests is usually not the right way. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
