Karthik Nayak <[email protected]> writes:
> --- a/ref-filter.c
> +++ b/ref-filter.c
> @@ -943,9 +943,23 @@ static int commit_contains(struct ref_filter *filter,
> struct commit *commit)
>
> /*
> * Return 1 if the refname matches one of the patterns, otherwise 0.
> + * A pattern can be a literal prefix (e.g. a refname "refs/heads/master"
> + * matches a pattern "refs/heads/m") or a wildcard (e.g. the same ref
> + * matches "refs/heads/m*", too).
> + */
> +static int match_pattern(const char **patterns, const char *refname)
> +{
> + for (; *patterns; patterns++)
> + if (!wildmatch(*patterns, refname, 0, NULL))
> + return 1;
> + return 0;
> +}
> +
> +/*
> + * Return 1 if the refname matches one of the patterns, otherwise 0.
> * A pattern can be path prefix (e.g. a refname "refs/heads/master"
> * matches a pattern "refs/heads/") or a wildcard (e.g. the same ref
While you're there, why not say explicitly
* A pattern can be path prefix (e.g. a refname "refs/heads/master"
* matches a pattern "refs/heads/" but not "refs/heads/m")
^^^^^^^^^^^^^^^^^^^^^^
...
(I find it frustrating when the docstrings for two function look
identical and I have to find out the 1-character difference to
understand ...)
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
