On Fri, Apr 15, 2016 at 4:32 PM, Jacob Keller <jacob.kel...@gmail.com> wrote: > On Fri, Apr 15, 2016 at 4:05 PM, Jacob Keller <jacob.kel...@gmail.com> wrote: >> There's a few places that will need cleaning up (comments and such) >> that mention empty line still, but that's not surprising. I am going >> to test this for a bit on my local repos, and see if it makes any >> difference to the old heuristic as well. >> >> Thanks, >> Jake >> > > I ran this heuristic on git.git and it produces tons of false positive > transforms which are much lease readable (to me at least), far more > than those produced by the newline/blank link heuristic did. > > I think we should stick with the empty line heuristic instead of this > version, even if it's easier to implement this version.
I agree. The heuristic is worse as we often have these 50:50 chances of messing stuff up. > > We still would need to figure out how to handle CRLF properly but it's > worth resolving that than this heuristic is. > > Thanks, > Jake -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
