Stefan Beller <sbel...@google.com> writes: > On Fri, Apr 29, 2016 at 5:21 AM, Matthieu Moy > <matthieu....@grenoble-inp.fr> wrote: >> Jeff King <p...@peff.net> writes: >> >>> On Fri, Apr 29, 2016 at 11:35:34AM +0200, larsxschnei...@gmail.com wrote: >>> >>>> +# The follow numbers need to be adjusted when new documentation is added. >>>> +test_file_count html 233 >>>> +test_file_count xml 171 >>>> +test_file_count 1 152 >>> >>> This seems like it will be really flaky and a pain in the future. I'm >>> not really sure what it's accomplishing, either. The earlier steps would >>> complain if something failed to render, wouldn't they? At some point we >>> have to have some faith in "make doc". >> >> I agree. My proposal to check for a handful of generated files was just >> because this extra paranoia was almost free (just 3 lines of code that >> won't need particular maintenance). >> >> In this case, I'm afraid the maintenance cost is much bigger than the >> expected benefits. > > So you proposed to check a handful files for its exact content?
No, just to check that the files exist and are non-empty, i.e. the "test -s" part of Lars' patch. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
