On 02 May 2016, at 22:45, Junio C Hamano <gits...@pobox.com> wrote: > larsxschnei...@gmail.com writes: > >> +set -e >> + >> +LINKS=$(grep --recursive --only-matching --no-filename --perl-regexp \ >> + '(?<=linkgit:).*?(?=\[\d+\])' Documentation/* \ >> + | sort -u \ >> +) >> + >> +for LINK in $LINKS; do >> + echo "Checking linkgit:$LINK..." >> + test -s Documentation/$LINK.txt >> +done > > Please separate the above link check out of this step and do so > separately after the move of test body to a separate script > settles. OK. I also wonder if the link check should rather go to the "check-docs" Makefile target?
> When you reintroduce the tests, please make sure the shell script > follow the coding style of other scripts. E.g. I do not think the > last one in the $(...) needs a backslash continuation at all. I am > assuming that you are doing this only on Linux, in which case use of > GNUism with grep may be fine. OK. Thanks for the review, Lars > >> +make check-builtins >> +make check-docs >> +make doc >> + >> +test -s Documentation/git.html >> +test -s Documentation/git.xml >> +test -s Documentation/git.1 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
