Hi Stefan, Stefan Beller <sbel...@google.com> writes: > [...] > @ -353,6 +354,15 @@ static int parse_config(const char *var, const char > *value, void *data) > else if (parse_submodule_update_strategy(value, > &submodule->update_strategy) < 0) > die(_("invalid value for %s"), var); > + } else if (!strcmp(item.buf, "shallow")) { > + if (!me->overwrite && > + submodule->recommend_shallow != -1)
Nit: You seems to be able to keep the whole condition on the same line: if (!me->overwrite && submodule->recommend_shallow != -1) If you want to keep it in two line, you might want to align it: if (!me->overwrite && submodule->recommend_shallow != -1) Thanks, RĂ©mi -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html