On 05/28/2016 05:04 PM, Matthieu Moy wrote:
Eric Wong <[email protected]> writes:
Samuel GROOT <[email protected]> wrote:
(mbox) Adding cc: A<[email protected]> from line 'Cc: A<[email protected]>,
One<[email protected]>'
(mbox) Adding cc: One<[email protected]> from line 'Cc: A<[email protected]>,
One<[email protected]>'
Though `git send-email` now outputs something like:
(mbox) Adding cc: A<[email protected]> from line 'Cc:
A<[email protected]>'
(mbox) Adding cc: One<[email protected]> from line 'Cc:
One<[email protected]>'
I actually like neither, and would prefer something shorter:
(mbox) Adding cc: A <[email protected]> from Cc: header
(mbox) Adding cc: One <[email protected]> from Cc: header
(mbox) Adding cc: SoB <[email protected]> from Signed-off-by: trailer
That way, there's no redundant addresses in each line and less
likely to wrap.
I agree with this. Actually, I'd even say that the current output of
"git send-email" looks sloppy, and internal refactoring may be a good
opportunity to get it cleaner.
I agree.
Should we take what Eric suggested (see below) as standard output?
Since the headers are already shown after those lines, it's
redundant to have the entire line. And we could add
trailers after the headers (with a blank line to delimit):
# existing header output:
From: F <[email protected]>
Cc: A <[email protected]>, One <[email protected]>
Subject: foo
# new trailer output
Signed-off-by: SoB <[email protected]>
Acked-by: ack <[email protected]>
And keep "(mbox) Adding ..." lines as error output, or maybe displayable
by a new option `--verbose`?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
