Hi Dscho,
Am 08.07.2016 um 08:33 schrieb Johannes Schindelin:
On Thu, 7 Jul 2016, René Scharfe wrote:
write_file() either returns 0 or dies, so there is no point in checking
its return value.
The question is whether it makes sense for write_file() to die(). It is a
library function and not every caller can be happy with that function to
exit the program when some file could not be written, without a chance to
tell the user what to do about the situation.
If write_file() was defined in builtin/am.c, as a static function, I would
grudgingly acquiesce, but it is not.
IMO it would be better to fix write_file() to *not* die() but return
error() instead.
there is write_file_gently() for that purpose, but it's used only by a
single caller that exits on failure after all, and in fact Peff's series
drops it.
So I think write_file() is fine, and it's rather a question of whether
am should use write_file_gently() instead. I don't see why, but perhaps
that's because it's Friday..
René
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
