On Fri, Jul 08, 2016 at 10:09:28AM -0700, Junio C Hamano wrote: > Junio C Hamano <[email protected]> writes: > > > As to the hunk to commit.c that was dropped in this round, the only > > caller of print_commit_list() is bisect.c, and it passes "%s\n" to > > format_cur and format_last, it seems, so that suggests a more > > obvious direction for cleaning things up, I would say. > > And the result is a pleasing diffstat. > > -- >8 -- > Subject: commit.c: remove print_commit_list()
Yeah, I agree this is a nice diffstat. As for the "walker" thing, I also agree that we don't really care much about it these days. I really wish we could just kill it off; it would simplify the http code significantly (e.g., the entire reason we have the whole async multi-fetch setup is to support it). But every time I think that, somebody mentions on the list that they are still using it. :-/ I do suspect we could kill off the http push-over-dav, though. It's less likely to be useful than the fetch code. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
