cjwmorgan-sol commented on issue #4: AMQNET-589: Failover implementation URL: https://github.com/apache/activemq-nms-amqp/pull/4#issuecomment-511240456 > @cjwmorgan-sol Off topic question. It was a conscious decision not to use "var" keyword in your original implementation? No I believe not, I remember an internal discussion about coding style and I do not recall var ever coming up, maybe @RagnarPaulson knows better? I think it was more of a personal coding style. There are some good reasons for and against using the keyword 'var', see [blog](https://intellitect.com/when-to-use-and-not-use-var-in-c/). At the time however I think the idea was to write "good descriptive code" for opensource and at the time, at least to me, using the keyword 'var' did not register to me as "good descriptive code". Although now I think the old original implementation could have had a few benefits from using var based on the aforementioned [blog](https://intellitect.com/when-to-use-and-not-use-var-in-c/) with maybe a code style section in the ReadMe.md to explain the desired uses for it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
