cjwmorgan-sol commented on issue #4: AMQNET-589: Failover implementation URL: https://github.com/apache/activemq-nms-amqp/pull/4#issuecomment-511454085 I find I only hit the case when I publish and receive more then 30 messages, I tried with 50 messages. Also I think the broker I'm using hits the issue in amqpnetlite https://github.com/Azure/amqpnetlite/issues/351 where sync sends take 1 sec per message. This makes the first 30 messages expired. Turns out my broker does not support the modified outcome for deliveries. This causes the exception to occur since the broker returns an outcome list without the modified outcome symbol, in the attach response so when the client sends an modified disposition the broker terminates the link. Would it be possible to have the AmqpConsumer check the attach response for support outcomes and do the following: 1. Determine if the list of supported outcomes is sufficient to process messages. If not fail to create the consumer. 1. For non critical protocol outcomes like modified could the client not send the outcome disposition on links that do not support the outcome.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
