killnine commented on a change in pull request #9: [AMQNET-565] - .net standard conversion, project reorganization URL: https://github.com/apache/activemq-nms-openwire/pull/9#discussion_r304427730
########## File path: test/nms-openwire-test.csproj ########## @@ -0,0 +1,66 @@ +<Project Sdk="Microsoft.NET.Sdk"> + + <PropertyGroup> + <TargetFramework>netcoreapp2.2</TargetFramework> Review comment: I think it makes sense to multi-target the main project, but why the test project? If we multi-target the main binaries, do I need to multi-target the test project simply so the test project can run against all the possible frameworks of the main project? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
