killnine commented on a change in pull request #9: [AMQNET-565] - .net standard conversion, project reorganization URL: https://github.com/apache/activemq-nms-openwire/pull/9#discussion_r311354627
########## File path: test/nms-openwire-test.csproj ########## @@ -0,0 +1,66 @@ +<Project Sdk="Microsoft.NET.Sdk"> + + <PropertyGroup> + <TargetFramework>netcoreapp2.2</TargetFramework> + <RootNamespace>Apache.NMS.ActiveMQ.Test</RootNamespace> + <AssemblyName>Apache.NMS.ActiveMQ.Test</AssemblyName> + <ApplicationIcon /> + <OutputType>Library</OutputType> + <StartupObject /> + <GeneratePackageOnBuild>true</GeneratePackageOnBuild> + <Company>Apache Software Foundation</Company> + <Authors>Apache ActiveMQ</Authors> + <Product>Apache NMS ActiveMQ</Product> Review comment: SHould be fixed... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
