michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451 
limit size of destination cache
URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313726708
 
 

 ##########
 File path: 
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnection.java
 ##########
 @@ -97,7 +98,7 @@
 
    private final Set<SimpleString> tempQueues = new ConcurrentHashSet<>();
 
-   private final Set<SimpleString> knownDestinations = new 
ConcurrentHashSet<>();
+   private final ConcurrentMaxSizeCache<SimpleString> knownDestinations = new 
ConcurrentMaxSizeCache<>(100);
 
 Review comment:
   Can we make this configurable (e.g. a setting in the CF), 100 is a bit of a 
magic number.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to