michaelandrepearce commented on a change in pull request #2794: ARTEMIS-2451
limit size of destination cache
URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313730591
##########
File path:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnection.java
##########
@@ -97,7 +98,7 @@
private final Set<SimpleString> tempQueues = new ConcurrentHashSet<>();
- private final Set<SimpleString> knownDestinations = new
ConcurrentHashSet<>();
+ private final ConcurrentMaxSizeCache<SimpleString> knownDestinations = new
ConcurrentMaxSizeCache<>(100);
Review comment:
this will actually cause issues if someone is using temp destinations, and
has say more than 100 legitimately. and creates the consumers later, as the
consumer will check it its known, which now it wont and will throw an error.
This will at least mean people can increase that setting if they need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
