michaelandrepearce commented on a change in pull request #2791: ARTEMIS-2450
page-size-bytes should not be greater than Integer.MAX_VALUE
URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r314188891
##########
File path:
artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/FileConfigurationParserTest.java
##########
@@ -257,6 +257,26 @@ public void
testParsingDefaultServerConfigWithENCMaskedPwd() throws Exception {
assertEquals("helloworld", bconfig.getPassword());
}
+ @Test
+ public void testParsingOverflowPageSize() throws Exception {
+ FileConfigurationParser parser = new FileConfigurationParser();
Review comment:
This test, test the new change, but doesnt test for what we are protecting
from. E.g whats the underlying issue being fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
