michaelandrepearce commented on a change in pull request #2791: ARTEMIS-2450
page-size-bytes should not be greater than Integer.MAX_VALUE
URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r314877174
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java
##########
@@ -505,6 +505,9 @@ public long getPageSizeBytes() {
}
public AddressSettings setPageSizeBytes(final long pageSize) {
+ if (pageSize > Integer.MAX_VALUE) {
+ throw new IllegalArgumentException("pageSize must be < " +
Integer.MAX_VALUE);
Review comment:
Not really. If you now decode something thats larger than int it will blow
up with the exception youve added. No different. Except we are actually making
the method take the correct primitive number
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
