orpiske commented on a change in pull request #5: ARTEMIS-2533 Support multiple
architecture for ASYNCIO kernel by-pass
URL:
https://github.com/apache/activemq-artemis-native/pull/5#discussion_r340192351
##########
File path:
src/main/c/org_apache_activemq_artemis_nativo_jlibaio_LibaioContext.c
##########
@@ -32,15 +32,11 @@
#include <fcntl.h>
#include <stdlib.h>
#include <pthread.h>
+#include <stdatomic.h>
#include <limits.h>
#include "org_apache_activemq_artemis_nativo_jlibaio_LibaioContext.h"
#include "exception_helper.h"
-//x86 has a strong memory model and there is no need of HW fences if just
Write-Back (WB) memory is used
-#define mem_barrier() __asm__ __volatile__ ("":::"memory")
-#define read_barrier() __asm__ __volatile__("":::"memory")
-#define store_barrier() __asm__ __volatile__("":::"memory")
-
Review comment:
I think you might run into problems with a few older GCC versions here. I
believe stdatomic requires GCC 5 or newer. You may work-around this with a few
cmake checks and fall back to the older format in the worst scenario. This
should be simple, IMHO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
