Havret commented on a change in pull request #12: NMS 2.0 WIP
URL: https://github.com/apache/activemq-nms-api/pull/12#discussion_r371025894
##########
File path: src/nms-api/IMessageProducer.cs
##########
@@ -54,6 +58,48 @@ public interface IMessageProducer : System.IDisposable
/// </summary>
void Send(IDestination destination, IMessage message,
MsgDeliveryMode deliveryMode, MsgPriority priority, TimeSpan timeToLive);
+ /// <summary>
+ /// Sends the message to the default destination for this
producer
+ /// </summary>
+ void Send(IMessage message, CompletionListener
completionListener);
Review comment:
As a .NET developer, I find it a bit odd to see an asynchronous API designed
with callbacks. I know that's the only way to do it in Java, but in my humble
opinion, we should leverage what language has to offer. I don't have a strong
opinion here though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
