Havret commented on a change in pull request #12: NMS 2.0 WIP URL: https://github.com/apache/activemq-nms-api/pull/12#discussion_r371026800
########## File path: src/nms-api/INMSConsumer.cs ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +using System; +using System.Threading.Tasks; + +namespace Apache.NMS +{ + + + + /// <summary> + /// An object capable of sending messages to some destination + /// </summary> + public interface INMSConsumer : System.IDisposable + { + + string MessageSelector { get; } + + /// <summary> + /// Waits until a message is available and returns it + /// </summary> + IMessage Receive(); + + /// <summary> + /// If a message is available within the timeout duration it is returned otherwise this method returns null + /// </summary> + IMessage Receive(System.TimeSpan timeout); + + /// <summary> + /// Receives the next message if one is immediately available for delivery on the client side + /// otherwise this method returns null. It is never an error for this method to return null, the + /// time of Message availability varies so your client cannot rely on this method to receive a + /// message immediately after one has been sent. + /// </summary> + IMessage ReceiveNoWait(Type t); Review comment: There is no need to pass `Type` here. We're just returning a message despite the type. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
