michaelandrepearce commented on a change in pull request #12: NMS 2.0 WIP
URL: https://github.com/apache/activemq-nms-api/pull/12#discussion_r371029353
##########
File path: src/nms-api/IMessageProducer.cs
##########
@@ -54,6 +58,48 @@ public interface IMessageProducer : System.IDisposable
/// </summary>
void Send(IDestination destination, IMessage message,
MsgDeliveryMode deliveryMode, MsgPriority priority, TimeSpan timeToLive);
+ /// <summary>
+ /// Sends the message to the default destination for this
producer
+ /// </summary>
+ void Send(IMessage message, CompletionListener
completionListener);
+
+ /// <summary>
+ /// Sends the message to the default destination with the
explicit QoS configuration
+ /// </summary>
+ void Send(IMessage message, MsgDeliveryMode deliveryMode,
MsgPriority priority, TimeSpan timeToLive, CompletionListener
completionListener);
+
+ /// <summary>
+ /// Sends the message to the given destination
+ /// </summary>
+ void Send(IDestination destination, IMessage message,
CompletionListener completionListener);
+
+ /// <summary>
+ /// Sends the message to the given destination with the
explicit QoS configuration
+ /// </summary>
+ void Send(IDestination destination, IMessage message,
MsgDeliveryMode deliveryMode, MsgPriority priority, TimeSpan timeToLive,
CompletionListener completionListener);
+
+
+ /// <summary>
+ /// Sends the message to the default destination for this
producer
+ /// </summary>
+ Task SendAsync(IMessage message);
+
+ /// <summary>
+ /// Sends the message to the default destination with the
explicit QoS configuration
+ /// </summary>
+ Task SendAsync(IMessage message, MsgDeliveryMode deliveryMode,
MsgPriority priority, TimeSpan timeToLive);
+
+ /// <summary>
+ /// Sends the message to the given destination
+ /// </summary>
+ Task SendAsync(IDestination destination, IMessage message);
+
+ /// <summary>
+ /// Sends the message to the given destination with the
explicit QoS configuration
+ /// </summary>
+ Task SendAsync(IDestination destination, IMessage message,
MsgDeliveryMode deliveryMode, MsgPriority priority, TimeSpan timeToLive);
Review comment:
yes, we will have to, i think that's fine, before we merge this, we should
make a 1.x branch for any maintenance needs on the older 1.x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
