gemmellr commented on code in PR #4824:
URL: https://github.com/apache/activemq-artemis/pull/4824#discussion_r1507323452
##########
artemis-cli/src/test/java/org/apache/activemq/cli/test/CliProducerTest.java:
##########
@@ -88,6 +90,124 @@ public void testSendMessage() throws Exception {
checkSentMessages(session, address, null);
}
+ @Test
+ public void testBooleanMessageProperties() throws Exception {
Review Comment:
I'd guess that Clebert was just thinking about it starting X brokers and
making X connections, sessions, producers currently to test something carried
on the message alone that could still be done with 1 of each.
I tend to prefer more granular tests. Although, I'd personally go further
and think the CLI bits could probably have been unit tested without any broker
etc since its just a case of verifying the arg is decoded as expected, and
ensuring things are set as expected on the message before it is sent...the
clients sending of a message with props is covered elsewhere already)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
